Fix: Empty Order List #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
mindgraffiti
approved these changes
Aug 9, 2018
Contributor
mindgraffiti
left a comment
mindgraffiti
left a comment
There was a problem hiding this comment.
✅ unit tests passing
✅ UI testing passing
looks good @jleandroperez
Contributor
Author
|
Thank you Thuy!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
We've spotted a testing site that was returning null SKU's, and this was effectively breaking our parsers.
In this PR we're:
SKUproperty as Optionalcc @bummytime @mindgraffiti (Thanks in advance!!)
Closes #221
Thanks @stephhjacq !!!
Testing:
Verify the unit tests look green!