Dashboard: data loading fixes #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpmobilebot
reviewed
Sep 20, 2018
| startListeningToNotifications() | ||
| tabBarItem.image = Gridicon.iconOfType(.statsAlt) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
| Lines should not have trailing whitespace. |
wpmobilebot
reviewed
Sep 20, 2018
| configureView() | ||
| reloadData() | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
| Lines should not have trailing whitespace. |
wpmobilebot
reviewed
Sep 20, 2018
| @IBOutlet private weak var bottomBorder: UIView! | ||
|
|
||
| private var periodVCs = [PeriodDataViewController]() | ||
|
|
Collaborator
There was a problem hiding this comment.
| Lines should not have trailing whitespace. |
wpmobilebot
reviewed
Sep 20, 2018
| vc.clearAllFields() | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
| Lines should not have trailing whitespace. |
mindgraffiti
approved these changes
Sep 20, 2018
Contributor
mindgraffiti
left a comment
mindgraffiti
left a comment
There was a problem hiding this comment.
✅ all testing scenarios
✅ code review
Contributor
Author
|
Thank you @mindgraffiti !! |
Contributor
|
Awesome!!!! |
designsimply
added
feature: stats
AliSoftware
added
feature: stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 3 issues with data loading in the Dashboard:
Previously, if the user logged out the old data was never cleared. To fix this I added a notification observer for
defaultAccountWasUpdated. If that notif is fired and the user is no longer authenticated, we clear the chart VCsAfter logging in or launching the app, the Dashboard data would not refresh and could possibly be blank (until the user pulled-to-refresh). Now we are looking for missing data on
viewDidAppearand reloading it if needed.The
Updated X minutes agotext on the chart is now cleared when pull-to-refresh is activated or the user logs out.NOTE: Most of this ☝️☝️☝️ will be replaced when #258 is addressed. The goal here is to give our open beta users a better experience.
Fixes #260
Testing
Scenario 1: Fresh Login
Updated X ... agotext is blank while data is loadingScenario 2: Logout -> Login
a. The
Updated X ... agotext is blank while data is loadingb. The Dashboard is not displaying any stale data from the previous store.
Misc Other Things
Dashboard -> Orders -> Dashboard— verify there isn't any double animations on the charts@mindgraffiti and/or @jleandroperez could you take a peek at this?