Notification Details: Pull to Refresh #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f8b2361.
jleandroperez
added
the
feature: notifications
bummytime
approved these changes
Nov 13, 2018
Contributor
bummytime
left a comment
bummytime
left a comment
There was a problem hiding this comment.
@jleandroperez your testing steps worked like a champ 🥊 . Code is square. 
!
| } | ||
|
|
||
| return storageNote.noteID == noteId && | ||
| storageNote.noteHash == hash |
Contributor
There was a problem hiding this comment.
I don't know why I even included this here originally 🤷♂️ 😆 !
Contributor
Author
There was a problem hiding this comment.
No worries!!! I've noticed because the "EntityListener" wasn't picking up the changes!
Contributor
Author
|
Thank you sir!! |
jleandroperez
deleted the
issue/19-notification-details-pull-to-refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Ref. #19
Note:
I've been struggling with the backend, trying to get a Product Review Notification updated. Bottom line is: i've been unsuccessful at doing so!!. In order to test this PR, we'll rely on a "local hack", to ensure a given notification is effectively updated.
Testing:
HACK Product Reviewcc @bummytime
Thanks in advance Matt!!!