Order Details: Adds price field to OrderItem and updates UI #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bummytime
added
type: bug
mindgraffiti
approved these changes
Jan 8, 2019
Contributor
mindgraffiti
left a comment
mindgraffiti
left a comment
There was a problem hiding this comment.
✅ unit tests
✅ code review
✅ UI testing
Thanks Matt!!
| /// - currency: a 3-letter country code for currencies that are supported in the API. e.g. "USD" | ||
| /// | ||
| func formatAmount(_ decimalAmount: NSDecimalNumber, with currency: String = CurrencySettings.shared.currencyCode.rawValue) -> String? { | ||
|
|
Contributor
Author
|
Thanks for the review @mindgraffiti !! |
Collaborator
Generated by 🚫 Danger |
Contributor
Author
|
Take it easy wpmobilebot! |
bummytime
added a commit
that referenced
this pull request
Jan 11, 2019
5 tasks
bummytime
added a commit
that referenced
this pull request
Jan 11, 2019
Reapply updates from "item price" PR (#577)
bummytime
added a commit
that referenced
this pull request
Jan 11, 2019
…s into fix/563-mark-as-read-notice * 'release/1.0.0' of github.com:woocommerce/woocommerce-ios: Updates from "item price" PR (#577)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
pricefield to the order item entities across the Networking, Storage, and Yosemite frameworks. Additionally it fixes the item price display issue on the order details and fulfillment screens:Notes:
OrderItemmodel includes price as a NSDecimalNumber. There are 2 reasons for this: 1) It makes formatting easier in the main Woo app and 2) even though the documentation claims the item price is a string, in reality, the response JSON returnspriceas a NumberpricefieldCurrencyFormatter'sformatAmount()func to accept aNSDecimalNumberas well as aString(and added some unit tests as well)Fixes: #358
Ref: #552
Testing
Here are some suggested testing steps, but feel free to test this however you want.
Build and run the app
Open the orders tab
Find an order with
Processingstatus where the line items have a quantity of 1Open the fullfillment screen
Find an order with
Completedstatus where the line items have a quantity of 1Open the item details screen
Find an order with
Processingstatus where the line items have a quantity of 2 or moreOpen the fullfillment screen
Find an order with
Completedstatus where the line items have a quantity of 2 or moreOpen the item details screen
@mindgraffiti and/or @astralbodies Could either of you give this PR a 👀 ? Thanks!!