Skip to content

Conversation

@brentmackinnon
Copy link
Contributor

Updating the backgrounds, logos, and favicons so we're using the right Woo Purple in the slate presentation of the docs.

Updating the backgrounds, logos, and favicons so we're using the right Woo Purple in the slate presentation of the docs.
Copy link
Contributor

@jonathansadowski jonathansadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a question about the link color, which was previously distinct from the background colors... it might be the case that it not being distinct is okay, but wanted to double-check first. I'll approve this, and if it's not an oversight, feel free to merge. Thanks for cleaning this up.

$aside-warning-bg: #ca4949 !default;
$aside-success-bg: #38a845 !default;
$search-notice-bg: #c97a7e !default;
$link-color: #804877;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were previously using a different purple here than the bg colors. Do you know if this should be the case here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathansadowski good question. I noticed that it was quite similar, and I wasn't sure the reason for having two similar colours, so I used our Woo purple for both here.

old link color: IMG002397
new link color: IMG002399

old bg color: IMG002398
new bg color:IMG002399

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, yep, that seems reasonable to me. I'll merge this, thanks again!

@jonathansadowski jonathansadowski merged commit 4197e2c into trunk May 3, 2023
@NeosinneR NeosinneR deleted the update/brand branch August 1, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants