Remove unused WorkerEndpoint protobuf message — Closes #125#126
Merged
conradbzura merged 1 commit intowool-labs:mainfrom Mar 26, 2026
Merged
Conversation
WorkerEndpoint was defined in wire.proto but never used anywhere in the codebase. Removing it keeps the wire protocol definition clean and avoids implying that the message is load-bearing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused
WorkerEndpointprotobuf message from the wire protocol definition and all associated exports and test references. The message was defined but never consumed anywhere in the codebase, creating a false impression that it was part of the active public API.Closes #125
Proposed changes
Remove WorkerEndpoint from wire.proto
Delete the empty
message WorkerEndpoint {}definition fromproto/wire.proto. No other protobuf messages or services reference it.Remove export from wool.protocol
Drop the
WorkerEndpointimport fromwire_pb2and remove it from__all__insrc/wool/protocol/__init__.py.Update test expectations
Remove
WorkerEndpointfrom theEXPECTED_MESSAGE_EXPORTSlist intests/protocol/test_wire.py. The existing parametrized export tests continue to validate all remaining protocol symbols.