fix(kitsu-core): allow longer prototype chain on serialise#444
Merged
wopian merged 1 commit intowopian:masterfrom Jul 16, 2020
mgebeily:allow-prototype-chain
Merged
fix(kitsu-core): allow longer prototype chain on serialise#444wopian merged 1 commit intowopian:masterfrom mgebeily:allow-prototype-chain
wopian merged 1 commit intowopian:masterfrom
mgebeily:allow-prototype-chain
Conversation
wopian
approved these changes
Jul 16, 2020
wopian
changed the title
Owner
|
Can you recreate the PR please? I accidentally hit https://github.com/mgebeily/kitsu/pull/new/allow-prototype-chain |
Contributor
Author
Sure thing! Thanks for getting to it so quickly: #447 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome library.
I'm currently using it in a TypeScript project with instantiated objects of a different type (i.e.,
const user = new User()). The validation that checks the object's prototype parent fails unless I clone the object (by passing in something like{ ...user }). I changed the validation to allow objects further down the prototype chain.Let me know if I'm missing the justification. Thanks again for your time.