Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
onequery-landing | eedd9a1 | Commit Preview URL Branch Preview URL |
Jun 01 2026, 02:37 AM |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eedd9a15c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,7 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"> | |||
There was a problem hiding this comment.
This commit replaces src/assets/onequery-icon.png with this SVG, but repo-wide search still shows the brand guide directing readers to the deleted PNG (apps/landing/docs/brand-guide/logo.md:14 and :160, plus apps/landing/docs/brand-guide/color.md:19). Anyone following the landing brand docs after this change is pointed at a nonexistent source asset, so the docs should be updated to reference the new SVG/public PNG split.
Useful? React with 👍 / 👎.
| logo: { | ||
| alt: "OneQuery", | ||
| src: "/src/assets/onequery-icon.png", | ||
| src: "/src/assets/onequery-icon.svg", |
There was a problem hiding this comment.
This now points the docs logo at a root-relative /src/... URL, but the SVG was added under src/assets and there is no matching public file under public/src/assets (checked the public tree and repo-wide references). Starlight’s source-asset logo form expects a project-relative path such as ./src/assets/..., so the deployed docs can still render a missing logo request instead of bundling the SVG.
Useful? React with 👍 / 👎.
1 participant
One-Line Summary
Stabilize OneQuery logo, favicon, and social preview assets so docs and landing pages no longer depend on broken optimized PNG paths.
User-Facing Changes
logo.srcconfig./og.pngfor broad crawler compatibility./favicon-96x96.png, while Apple touch uses/apple-touch-icon.png./onequery-icon.pngremains as the stable 512x512 public brand logo for JSON-LD and crawler metadata.Why This Changed
The deployed docs page previously referenced an optimized
/_astro/onequery-icon.*.pngpath that was missing in the Cloudflare Workers build. The source PNG also existed in bothsrc/assetsandpublic, which made the intended ownership unclear. SVG is the better source format for the rendered app logo, while social cards and favicons need stable public PNG files for crawler and platform compatibility.How It Changed
src/assets/onequery-icon.svgand pointed Starlight docs logo config to that SVG./favicon-96x96.pngforrel="icon"and Starlight favicon config./apple-touch-icon.pngfor Apple touch surfaces.src/assets/og.pngsrc/assets/onequery-icon.pngBug Fixes
/_astro/. This change moves the docs logo to a generated SVG asset path and keeps crawler-facing PNG URLs inpublic/.Performance Notes
Raw file-size comparison:
public/og.pngsrc/assets/og.pngsrc/assets/onequery-icon.png->src/assets/onequery-icon.svgpublic/onequery-icon.pngpublic/favicon-96x96.pngpublic/apple-touch-icon.pngExtra Context / Decisions
Verification
rtk bun run typecheckrtk bun run buildrtk bun run formatrtk git push -u origin iconfix(pre-pushlint-fullpassed with 0 warnings and 0 errors)Video / Screenshot (Optional)