Issue/245 image in paragraph #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theck13
reviewed
Feb 11, 2017
Contributor
theck13
left a comment
theck13
left a comment
There was a problem hiding this comment.
I had some minor comments. Everything else looks good!
| } | ||
| } | ||
|
|
||
| //<<<<<<< HEAD |
Contributor
Author
There was a problem hiding this comment.
Good catch, time to get rid of it.
| .any { | ||
| selectionStart == editableText.getSpanEnd(it) | ||
| } | ||
| val spanAtEndOfWhichMediaIsAdded = editableText.getSpans(selectionStart, selectionEnd, AztecBlockSpan::class.java) |
Contributor
There was a problem hiding this comment.
It looks like spanAtEndOfWhichMediaIsAdded was renamed similar to spanAtStartOfWhichMediaIsAdded. What about naming them spanBeforeMedia and spanAfterMedia, respectively? That's easier to grok.
Contributor
Author
There was a problem hiding this comment.
Oh yeah :) makes sense..
Contributor
Author
|
Thanks for the quick review @theck13. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245.
Can someone have a quick look so that it can be included in the release? Thanks!