Issue/fix block styling of empty lines #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Android into issue/fix-block-styling-of-empty-lines
…-Android into issue/fix-block-styling-of-empty-lines # Conflicts: # CHANGELOG.md
0nko
reviewed
Aug 13, 2017
|
|
||
| ### Fixed | ||
| - Image/video loading placeholder drawable usage | ||
| - Quote styling of the paragraph ends, empty and mixed lines |
Contributor
Author
|
Good catch! Fixed. |
Contributor
|
Nice, it works now. Another thing I tried was apply the quote to an empty list item. Each time a new nested blockquote gets created, it's never removed. Is that expected? |
Contributor
Author
|
Contributor
|
Turns out I forgot to pull the last commit. 🤦♂️ Nevermind. |
0nko
approved these changes
Aug 14, 2017
Contributor
|
Good job! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #418 (and bunch of related functionality)
This PR fixes block styling in ambiguous situations. Apparently, people style all kind of weirdly selected text!
The original issue happened when you applied quote to the selection that included \n at the end.
This was one of the many problems that were caused by issues in detecting the quote in selection, and bounds of the paragraphs.
There are a lot of scenarios where problems were happening, and I think I recreated all of them in tests.