Skip to content

Conversation

@MatisseHack
Copy link
Contributor

  • Updated UI tests to use the page object pattern
  • Added image tests
  • Added mixed list test

Test

  1. Run all tests in androidTest

@0nko
Copy link
Contributor

0nko commented Sep 27, 2017

When I run the unit tests, testMixedList() is failing because the expected value doesn't reflect the actual behavior. When you tap a single item in a list and change the list type, the entire list changes, which is the correct way.

@MatisseHack
Copy link
Contributor Author

I was under the impression that only the list item(s) selected should change type. If the whole list should change, then that is inconsistent with iOS. Not sure which is correct, but it's an easy fix either way.

cc @aerych

@aerych
Copy link

aerych commented Sep 27, 2017

Thanks @0nko. @MatisseHack if its no trouble could we update the test as @0nko described?

@MatisseHack
Copy link
Contributor Author

No trouble at all

@0nko
Copy link
Contributor

0nko commented Sep 28, 2017

Thanks @MatisseHack! Looks good. I'll go ahead and merge this.

:shipit:

@0nko 0nko merged commit a566167 into wordpress-mobile:develop Sep 28, 2017
@aerych
Copy link

aerych commented Sep 28, 2017

Thank you @0nko & @MatisseHack :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants