Skip to content

Conversation

@planarvoid
Copy link
Contributor

Fix

The task list is facing some issues when the checkbox is clicked. In this PR these should be fixed.
The issues are when you add an item in the middle of the task list or when you try to click on an empty item at the end of the list. Please check whether the task list works as expected (if you can think of other test scenarios).

Test 1

  1. Create a task list with multiple items
  2. Add an item in the middle of the list
  3. Try checking/unchecking the item and all the items around it
  4. Confirm that the items are checked correctly

Test 2

  1. Create a task list with multiple items at the end of the document
  2. Add an empty item at the end of the list
  3. Move cursor in one of the non-empty items
  4. Click on the empty item checkbox
  5. Notice it gets checked correctly

Review

@AmandaRiu

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@planarvoid planarvoid requested a review from AmandaRiu March 29, 2022 09:41
@planarvoid planarvoid self-assigned this Mar 29, 2022
@AmandaRiu AmandaRiu self-assigned this Mar 30, 2022
Copy link
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great @planarvoid! :shipit:

@AmandaRiu AmandaRiu merged commit 5cebfd8 into trunk Mar 30, 2022
@AmandaRiu AmandaRiu deleted the fix/task-list-click-issues branch March 30, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants