Allow replacement of last empty line on Aztec #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etoledom
approved these changes
Jun 14, 2019
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
Thank you for this improvements!
Tested via wordpress-mobile/gutenberg-mobile#1129 (review)
Do you think it could be possible to add a unit test to cover the issue fixed in the last commit?
wordpress-mobile/gutenberg-mobile#1129 (review)
Contributor
Author
|
@etoledom Added the test you required and corrected a typo on the variable name. Waiting for CI to finish it to merge this in. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the replacement of last empty lines inserted by the serialisers to be replaced to a specific character.
This is special important on handling HTML that consistent in single empty list elements or quote elements where the style needs to be applied to empty lines.
To test: