Update project to Swift 5 and xCode11 #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtreanor
reviewed
Sep 23, 2019
|
|
||
| workflows: | ||
| test_and_validate: | ||
| jobs: |
Contributor
There was a problem hiding this comment.
You will need to update the orb version above this to ios: wordpress-mobile/ios@0.0.32 so it has the needed fixes.
jtreanor
reviewed
Sep 23, 2019
.circleci/config.yml
Outdated
| pod-install: false | ||
| workspace: Aztec.xcworkspace | ||
| scheme: AztecExample | ||
| device: iPhone XS |
Contributor
There was a problem hiding this comment.
This should be iPhone 11. Xcode 11 does not come with an iPhone XS simulator by default.
Contributor
|
One other issue – in order to compile this, we'll need to update Gridicons as well. I can take care of that – I'll tag you in the dependent PR? |
Contributor
Author
|
@jtreanor I followed your tips, but I'm still having trouble with CircleCI... any more ideas? |
Contributor
|
@SergioEstevao It looks like you will need to update CocoaPods to at least 1.7.x for Xcode 11 compatibility. You can update this line to |
Contributor
Author
|
@jtreanor it worked! Do you mind review it now? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test: