Skip to content

Make underline action use a span and css by default. #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2019
Merged

Make underline action use a span and css by default. #1213

merged 1 commit into from
Sep 30, 2019

Conversation

@SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 30, 2019 •
edited
Loading

Fixes #1212

To test:

  • Open the demo app
  • Select empty content
  • write some text
  • Apply the underline style with the toolbar
  • Switch to HTML and check that the HTML uses the <span style="text-decoration: underline"> element.
  • Repeat but now apply the style using the shortcut menu by selecting the text and then tapping the BIU option in the context menu.

@SergioEstevao SergioEstevao added this to the Next Stable milestone Sep 30, 2019
etoledom
etoledom approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as described 🎉

@SergioEstevao SergioEstevao merged commit 4b6cc3d into develop Sep 30, 2019
@SergioEstevao SergioEstevao deleted the issue/span_underline branch September 30, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koke koke Awaiting requested review from koke

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Enhancement

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

Make underline style use span and css by default

3 participants

@SergioEstevao @etoledom