Skip to content

Conversation

@jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Oct 8, 2019

This requires wordpress-mobile/circleci-orbs#40 to be merged.

We have a problem with the CocoaPod publishing workflow for Aztec-iOS. WordPress-Aztec-iOS.podspec is a dependency of WordPress-Editor-iOS.podspec. This means that when the version numbers in the podspecs are bumped prior to making a new release, CI fails to validate WordPress-Editor-iOS.podspec because it can't find the new version of WordPress-Aztec-iOS.

The solution is to make use of a reasonably recent addition to CocoaPods (CocoaPods/CocoaPods#8536) which allows us to include local podspecs during validation and avoid searching the specs repo for WordPress-Aztec-iOS.

To test:

CI

  • See that CI is still green when validating against the local podspec.

Test locally

  1. Bump the version number in WordPress-Aztec-iOS.podspec and WordPress-Editor-iOS.podspec to something not yet released (e.g. 1.2.0) but don't commit your changes.
  2. Run bundle exec pod lib lint WordPress-Editor-iOS.podspec --include-podspecs=WordPress-Aztec-iOS.podspec and see that validation passes even though this version isn't released yet.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested local steps and CI is ✅

Looks great! Thank you @jtreanor 🙏

@jtreanor jtreanor merged commit 1b53a74 into develop Oct 9, 2019
@jtreanor jtreanor deleted the circleci-validate branch October 9, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants