Skip to content

Conversation

@SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Apr 27, 2020

Adds support for superscript and subscript elements on Aztec.

Screenshot 2020-04-28 at 15 52 26

To test:

  • Run the demo app
  • Check the Standard demo
  • See if the demo superscript and subscript content show up correctly
  • Play around with the elements
  • Swift to HTML mode and see if the HTML is still correct
  • Switch to Visual mode and see if all show correctly.

@SergioEstevao SergioEstevao added this to the 1.19.0 milestone Apr 27, 2020
@SergioEstevao SergioEstevao marked this pull request as ready for review April 28, 2020 14:53
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SergioEstevao! This looks super good 🎉

I did notice one small issue though:
Trying to continue typing after the last subscript I couldn't escape it:

This is the generated HTML:

This is superscript<sup>(1)</sup> and this is subscript<sub>(2) oh no!</sub></p>
<p><sub>Can't scape it even with new line </sub></p>

@SergioEstevao
Copy link
Contributor Author

Trying to continue typing after the last subscript I couldn't escape it:

I had a look on this, and I think this is expected behaviour, but because we lack buttons on the toolbar to enable disable it we cannot get rid of it.

This was also more evident because the html missed a <br> at the end of the line.
Just moving the example to another line and add adding the breakline it works like the others.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is expected behaviour

Interesting! I didn't expected it to be the right behaviour.
In that case let's :shipit: 🎉

@SergioEstevao SergioEstevao merged commit 0f67ee1 into develop Apr 29, 2020
@SergioEstevao SergioEstevao deleted the issue/implement_sup_sub branch April 29, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants