Skip to content

Fix: Cutting Attachments #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2017
Merged

Fix: Cutting Attachments #409

merged 1 commit into from
Apr 11, 2017

Conversation

@jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Apr 11, 2017

Testing:

  1. Insert a Horizontal Line
  2. Insert a More separator
  3. Switch to HTML Edition. Insert <unknown/>
  4. Switch back to Rich Edition mode
  5. Select all of the contents
  6. Cut the contents + Paste

Verify that everything looks as expected!

Needs Review: @diegoreymendez
Closes #408

Thanks in advance Diego!

@jleandroperez jleandroperez added this to the Version 1.0 Beta 1 milestone Apr 11, 2017
@jleandroperez jleandroperez self-assigned this Apr 11, 2017
diegoreymendez
diegoreymendez approved these changes Apr 11, 2017
View reviewed changes
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. Awesome work @jleandroperez!

@jleandroperez
Copy link
Contributor Author

jleandroperez commented Apr 11, 2017

Thanks sir!

@jleandroperez jleandroperez merged commit 27817fa into develop Apr 11, 2017
@jleandroperez jleandroperez deleted the issue/408-fixing-attachments-cut branch April 11, 2017 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diegoreymendez diegoreymendez diegoreymendez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@diegoreymendez diegoreymendez

Labels

[Type] Bug

Projects

None yet

Milestone

Version 1.0 Beta 1

Development

Successfully merging this pull request may close these issues.

3 participants

@jleandroperez @diegoreymendez