Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Add UI tests for simple text formatting #423
This PR adds a suite of UI tests for simple text formatting in the Aztec demo app.
They test each of the text formatting buttons in the toolbar (including the hr and more tags). The tests for lists are currently disabled, pending lists being fully implemented in Aztec.
diegoreymendez left a comment •
This is a great work!
I pointed out some minor style differences to make the code standard across our codebase. Check out the inline comments for more info on this.
The bigger issue I found is that all tests are all failing for me due to an issue with
Check out this comment for a working fix for it (tested and working fine here).
I updated the tests based on the feedback so far. A few notes:
@catehstn please let me know if this addresses your earlier feedback and if you see any other issues with these changes. Thanks!
catehstn left a comment •
I ran and the list ones are failing. I think comment them out and we can uncomment them when that functionality is there.
Also if you need to pause to insert multiple things, you could try waitForElementToAppear.
LGTM! Thanks :)