Skip to content

Conversation

@jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Apr 19, 2017

Details:

In this PR we're nuking the Zero Width Character from the Blockquote Formatter's innerworking.

Thanks in advance sir!
Needs Review: @diegoreymendez

Closes #422

--

Scenario A: Missing Blockquote after Backspace

  1. Launch the empty editor
  2. Toggle the Blockquote format
  3. Enter any random text
  4. Hit backspace

Verify that the blockquote style is still present.

Scenario B: Nuking Blockquote after Backspace

  1. Launch the empty editor
  2. Toggle the Blockquote format
  3. Enter any random text
  4. Select the end of the document
  5. Hit backspace

Verify that the Blockquote gets effectively removed.

Scenario C: Newline after blockquote

  1. Launch the empty editor
  2. Toggle the Blockquote format

Verify that a newline is inserted below the blockquote.

Scenario D: Nuking bottom \n and adding newlines

  1. Launch the empty editor
  2. Toggle the Blockquote format
  3. Enter any random text
  4. Select the end of the document
  5. Hit backspace
  6. Hit \n and enter any random text

Verify that the new Blockquote line gets it's proper style, even when the bottom \n was initially nuked.

Scenario E: Typing Attributes below Blockquote

  1. Launch the empty editor
  2. Toggle the Blockquote format
  3. Press the arrow down

Verify that the blockquote gets removed from the typing attributes (and that the text indentation looks normal).

Scenario F: Autoremoval after hitting return on newline

  1. Launch the empty editor
  2. Toggle the Blockquote format
  3. Hit return

Verify that the blockquote gets removed.

Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jleandroperez
Copy link
Contributor Author

Wooooooo

Thanks Diego!!

@jleandroperez jleandroperez merged commit 576898e into develop Apr 19, 2017
@jleandroperez jleandroperez deleted the issue/422-nuking-zero-width-spaces-from-blockquotes branch April 19, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants