-
Notifications
You must be signed in to change notification settings - Fork 149
Blockquotes: Nuking Zero Width Spaces #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jleandroperez
merged 14 commits into
develop
from
issue/422-nuking-zero-width-spaces-from-blockquotes
Apr 19, 2017
Merged
Blockquotes: Nuking Zero Width Spaces #428
jleandroperez
merged 14 commits into
develop
from
issue/422-nuking-zero-width-spaces-from-blockquotes
Apr 19, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
approved these changes
Apr 19, 2017
Contributor
diegoreymendez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Contributor
Author
|
Wooooooo Thanks Diego!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
In this PR we're nuking the Zero Width Character from the Blockquote Formatter's innerworking.
Thanks in advance sir!
Needs Review: @diegoreymendez
Closes #422
--
Scenario A: Missing Blockquote after Backspace
Verify that the blockquote style is still present.
Scenario B: Nuking Blockquote after Backspace
Verify that the Blockquote gets effectively removed.
Scenario C: Newline after blockquote
Verify that a newline is inserted below the blockquote.
Scenario D: Nuking bottom
\nand adding newlines\nand enter any random textVerify that the new Blockquote line gets it's proper style, even when the bottom
\nwas initially nuked.Scenario E: Typing Attributes below Blockquote
Verify that the blockquote gets removed from the typing attributes (and that the text indentation looks normal).
Scenario F: Autoremoval after hitting return on newline
Verify that the blockquote gets removed.