Feature/165 433 video in html #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
approved these changes
Apr 21, 2017
Contributor
jleandroperez
left a comment
jleandroperez
left a comment
There was a problem hiding this comment.
Working perfectly!!! added just a nipticky var name comment.
!!
| let newUrl = new?.srcURL | ||
|
|
||
| let addImageUrl = originalUrl == nil && newUrl != nil | ||
| let removeImageUrl = originalUrl != nil && newUrl == nil |
Contributor
There was a problem hiding this comment.
Nipticky: These two should probably be addVideoUrl and removeVideoUrl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165 and #433
This PR adds support for video insertion trough the formatting toolbar and implements HTML/DOM changes when videos are added/removed.
To test: