Fixes blockquotes and lists. #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
changed the title
jleandroperez
approved these changes
Apr 25, 2017
Contributor
jleandroperez
left a comment
jleandroperez
left a comment
There was a problem hiding this comment.
on my side sir. Unit tests passing, and all of the known Blockquote / Lists edge cases are working great (on the device + sim).
Contributor
Author
|
I'm merging now, and we can treat any remaining items in separate issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Initial implementation of blockquote and lists support for visual-mode editing in Aztec.
Closed #150 and #179.
Details:
This does not cover nested lists, or nesting lists inside blockquotes and vice-versa. It does offer additional support for handling paragraph tags, and pre tags as well.
How to test:
Test in WPiOS using branch
try/aztec-latest.Test in Aztec using branch
issue/150-propagate-list-edits-to-html.