Skip to content

Conversation

@SergioEstevao
Copy link
Contributor

Fixes #448

This PR adds support for nested lists only.
It's still not 100% but I wanted @diegoreymendez and @jleandroperez have a look on the code until now, and play around to see if they see any major issues.

I will continue to work in fixing the failing unit tests.

To test:

  • Run the sample app and check if the content shows correctly
  • Interact around the nested lists and see if all is working correctly
  • Interact on regular lists and see if all things are still working.

@SergioEstevao
Copy link
Contributor Author

So I fixed the unit tests by adding an option on the formatters to say if we are increasing the depth of the list or just replacing the current level.

I tested it a bit and it looks it's working pretty well on the visual side. On the DOM it looks that when you change the list type on a nested list if gets a bit confused and moves the nested list out of the <li> element. @diegoreymendez do you mind to give it a look?

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on my end!!

:shipit:

@SergioEstevao
Copy link
Contributor Author

Discussed with @diegoreymendez online and decided that we can tackle the DOM issues on a later PR after a newline refactor that is on the way.

@SergioEstevao SergioEstevao merged commit 4d3c1c8 into develop May 9, 2017
@SergioEstevao SergioEstevao deleted the issue/nested_lists_blockquotes branch May 9, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Nested Lists Support

3 participants