Skip to content

Shift + enter no longer breaks paragraphs. #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2017
Merged

Shift + enter no longer breaks paragraphs. #557

merged 4 commits into from
Jun 22, 2017

Conversation

@diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Jun 22, 2017 •
edited
Loading

Fixes #553

To test:

  • Launch the Demo with data, and make sure the lists look fine.
  • Launch the empty Demo, and insert a list.
  • Pressing shift + enter should no longer break paragraphs, and produce <br> elements in the HTML.

@diegoreymendez diegoreymendez added this to the Version 1.0 Beta 5 milestone Jun 22, 2017
SergioEstevao
SergioEstevao approved these changes Jun 22, 2017
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

@diegoreymendez diegoreymendez merged commit 44efc6a into develop Jun 22, 2017
@diegoreymendez diegoreymendez deleted the issue/553-shift-enter branch June 22, 2017 12:54
@diegoreymendez
Copy link
Contributor Author

diegoreymendez commented Jun 22, 2017

Thank you @SergioEstevao !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@jleandroperez jleandroperez Awaiting requested review from jleandroperez

Assignees

@SergioEstevao SergioEstevao

@jleandroperez jleandroperez

Labels

[Priority] High [Type] Enhancement

Projects

None yet

Milestone

Version 1.0 Beta 5

Development

Successfully merging this pull request may close these issues.

4 participants

@diegoreymendez @SergioEstevao @jleandroperez