Implement undo and redo when removing attachments by code. #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
A few comments added.
| } | ||
|
|
||
|
|
||
| /// Return the range of an attachment with the specified identifier if any |
Contributor
There was a problem hiding this comment.
Consistency: Let's make sure this comment is formatted with similar spacing as the rest of the comments.
Aztec/Classes/TextKit/TextView.swift
Outdated
| } | ||
|
|
||
| /// Removes the attachments that match the attachament identifier provided from the storage | ||
| /// Removes the attachment that match the attachment identifier provided from the storage |
Contributor
There was a problem hiding this comment.
Replace "match" with "matches"
| guard let range = storage.rangeFor(attachmentID: attachmentID) else { | ||
| return | ||
| } | ||
| let originalText = storage.attributedSubstring(from: range) |
Contributor
There was a problem hiding this comment.
From line 983 to line 990 we're repeating code that's in several other places in TextView.swift
Why not implement in TextView.swift method
func replaceCharacters(in: range, with attrString: NSAttributedString)
to take care of unified undo support?
Contributor
Author
There was a problem hiding this comment.
Good suggestion may I do this in another PR just dedicated to that refactor?
| /// - Parameter attachmentID: the unique id of the attachment | ||
| /// | ||
| open func remove(attachmentID: String) { | ||
| storage.remove(attachmentID: attachmentID) |
Contributor
There was a problem hiding this comment.
This method is no longer called from anywhere in the code. We should remove it from TextStorage.swift.
# Conflicts: # AztecTests/TextViewTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the capability of undo redo when removing an attachment by pressing on it and select the option remove.
To test: