Skip to content

Conversation

@SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jun 29, 2017

Closes #577

This issue resulted from the Removal of Gridicons done here: #559

The resources where not added to the pod, so this made application that used the pod crash when trying to access a resource.

To test:

  • The easiest way to test this is to try this version directly on the main WPiOS app.

Note: @diegoreymendez because we are using CocoaPods should convert the Example app to use CocoaPods instead of Carthage? This will make it easier to find this kind of issue.

@diegoreymendez
Copy link
Contributor

diegoreymendez commented Jun 29, 2017

because we are using CocoaPods should convert the Example app to use CocoaPods instead of Carthage? This will make it easier to find this kind of issue.

WordPress is using the library through CocoaPods, but that doesn't mean this library is only intended for use through CocoaPods.

I haven't tested it yet, since WPiOS uses CocoaPods, but the idea is Aztec should be usable through Carthage as well.

@SergioEstevao
Copy link
Contributor Author

@diegoreymendez maybe two example projects? one with pods another with Carthage?

I just suggest this because it will make it easier and earlier to detect this kind problem.

@diegoreymendez
Copy link
Contributor

If we had problems with CocoaPods often I could agree, but these issues are very sporadic.

The downside of having two example projects and having to keep them in synch would affect us far more often.

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao SergioEstevao merged commit c544fbb into develop Jun 29, 2017
@SergioEstevao SergioEstevao deleted the issue/fix_podspec_file_resources branch June 29, 2017 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants