Skip to content

Conversation

@frosty
Copy link
Contributor

@frosty frosty commented Jun 30, 2017

I hope this is okay coming into the release branch, but it's just a tiny fix to the colours of the format bar items. Previously disabled items had the wrong tint colour (iOS was adding its own adjustments), and we weren't including the overflow toggle button when setting colors.

formatbar-fix

To test:

  • Build and run, open Aztec. Enter HTML mode, and check:
    • The disabled items and the overflow toggle (...) should match in color
    • They should match the 'after' color in the screenshot above.

Needs review: @SergioEstevao
cc @diegoreymendez

@frosty frosty added this to the Version 1.0 Beta 6 milestone Jun 30, 2017
@frosty frosty requested a review from SergioEstevao June 30, 2017 16:14
@jleandroperez jleandroperez self-requested a review July 3, 2017 14:38
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!!

:shipit:

@frosty frosty merged commit b091555 into release/1.0.0-beta.6 Jul 3, 2017
@frosty frosty deleted the fix/format-bar-colors branch July 3, 2017 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants