Skip to content

Backport: Support for Tab + Shift Tab #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diegoreymendez merged 5 commits into from
Jul 4, 2017
Merged

Backport: Support for Tab + Shift Tab #586

diegoreymendez merged 5 commits into from
Jul 4, 2017

Conversation

@jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Jul 4, 2017

Backports #584 into Beta 6

To test:

  1. Launch an Empty Document
  2. Add an Ordered / Unordered List
  3. Hit Tab and verify a new indentation level is added
  4. Repeat and verify up to 7 indentation levels are added
  5. Try Shift Tab and verify an indentation level is removed
  6. Try the Shake gesture, and verify the Undo OP works as expected

cc @diegoreymendez
Thanks in advance!!

@jleandroperez jleandroperez added this to the Version 1.0 Beta 6 milestone Jul 4, 2017
@jleandroperez jleandroperez self-assigned this Jul 4, 2017
diegoreymendez
diegoreymendez approved these changes Jul 4, 2017
View reviewed changes
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

@diegoreymendez
Copy link
Contributor

diegoreymendez commented Jul 4, 2017

Merging to create a new release.

@diegoreymendez diegoreymendez merged commit cc40df2 into release/1.0.0-beta.6 Jul 4, 2017
@diegoreymendez diegoreymendez deleted the issue/backporting-nested-lists-shortcuts branch July 4, 2017 15:41
@jleandroperez jleandroperez mentioned this pull request Jul 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diegoreymendez diegoreymendez diegoreymendez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jleandroperez jleandroperez

Labels

[Type] Enhancement

Projects

None yet

Milestone

Version 1.0 Beta 6

Development

Successfully merging this pull request may close these issues.

3 participants

@jleandroperez @diegoreymendez