Skip to content

UnsupportedHTML: Multiple Updates #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 1, 2017
Merged

UnsupportedHTML: Multiple Updates #671

merged 7 commits into from
Aug 1, 2017

Conversation

@jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Aug 1, 2017

Details:

In this PR we're updating the UnsupportedHTML property:

  • UnsupportedHTML is now immutable. Win: subranges are enforced to require a new copy, whenever a new UnsupportedHTML entity shows up.
  • UnsupportedHTML now contains an array of HTMLElementRepresentation. We were, previously, storing an ElementNode with an entire subtree, which was the source of multiple Tree Generation issues.
  • Multiple UnitTests added + fixed!

Ref #658

To test:

Run the unit tests and make sure everything is happy!

cc @diegoreymendez

@jleandroperez jleandroperez added this to the Version 1.0 Beta 10 milestone Aug 1, 2017
@jleandroperez jleandroperez self-assigned this Aug 1, 2017
diegoreymendez
diegoreymendez approved these changes Aug 1, 2017
View reviewed changes
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@jleandroperez
Copy link
Contributor Author

jleandroperez commented Aug 1, 2017

Thank you!!

@jleandroperez jleandroperez merged commit c2da346 into develop Aug 1, 2017
@jleandroperez jleandroperez deleted the issue/658-unsupported-html-fixes branch August 1, 2017 16:42
@jleandroperez jleandroperez mentioned this pull request Aug 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diegoreymendez diegoreymendez diegoreymendez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jleandroperez jleandroperez

Labels

[Type] Bug

Projects

None yet

Milestone

Version 1.0 Beta 9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@jleandroperez @diegoreymendez