Skip to content

Conversation

@diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Aug 24, 2017

This PR:

  • Tones down the use of the Converter protocol, since it's really not bringing the advantages I hoped it would. We could eventually end up removing it entirely but that's outside the scope of this particular PR.
  • Renames some classes to make them more intuitive:
    • InHTMLConverter -> HTMLParser
    • OutHTMLConverter -> HTMLSerializer
    • NSAttributedStringToNodes -> AttributedStringParser
    • HTMLNodeToNSAttributedString -> AttributedStringSerializer
  • Relocates several files.

How to test:

Review the new hierarchy by opening the project and looking at it.
Make sure there aren't duplicated files.
Run the unit tests.

Integration:

I've tested and none of the changes in this PR affect our current WPiOS integration.

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good simplification !

@diegoreymendez diegoreymendez merged commit 9fb4a58 into develop Aug 24, 2017
@diegoreymendez diegoreymendez deleted the try/add-element-processor branch August 24, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants