Fixing Xcode 9 Build Errors #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@diegoreymendez I've mapped this PR to Beta 11, please, feel free to reassign, not really sure where it should go! |
Contributor
|
Whenever in doubt remember that:
Moving this to |
diegoreymendez
approved these changes
Aug 29, 2017
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
One optional comment, but ready to go. Nice job.
| public static func ==(lhs: NSRange, rhs: NSRange) -> Bool{ | ||
| return lhs.location == rhs.location && lhs.length == rhs.length | ||
| #if swift(>=3.2) | ||
| // No Op |
Contributor
There was a problem hiding this comment.
No need to specify with a comment though, it's self evident!
Contributor
Author
There was a problem hiding this comment.
If it's okay with you, let's leave it! love the way NO-OP reads, reminds me of the good old ASM days.
Contributor
Author
|
Thanks Diego! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
(Void) -> Voidare now enforced to be() -> VoidImage Providerthat was causing a crashTo test:
cc @diegoreymendez @SergioEstevao