Skip to content

Conversation

@frosty
Copy link
Contributor

@frosty frosty commented Aug 30, 2017

Refs wordpress-mobile/WordPress-iOS#7763 in WPiOS

This PR adds animation when switching the format bar's defaultItems and overflowItems collections.

To ensure a smooth transition, I've made the the defaultItems and overflowItems properties read-only and added a new setDefaultItems(_:overflowItems:) method to set them both at the same time.

format-bar-anim-1

To test:

Needs review: @SergioEstevao

@frosty frosty added this to the Beta 12 (next stable) milestone Aug 30, 2017
@frosty frosty requested a review from SergioEstevao August 30, 2017 13:49
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, new animations are excellent!

@frosty
Copy link
Contributor Author

frosty commented Aug 31, 2017

Thanks @SergioEstevao!

@frosty frosty merged commit 76e94b6 into develop Aug 31, 2017
@frosty frosty deleted the feature/format-bar-animation branch August 31, 2017 12:56
@diegoreymendez diegoreymendez modified the milestones: Beta 12 (next stable), Beta 11 (bugfixes) Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants