Not Loosing Styles! #717
Merged
Not Loosing Styles! #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-not-loosing-styles-anymore
…-not-loosing-styles-anymore
…ing-styles-anymore
jleandroperez
changed the title
Contributor
Author
|
Merging after waiting for way over an hour, for Travis to wrap up it's build. Thanks Diego! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
In this PR we're adding several Paragraph Analysis helpers, and switching the mechanism that removes Styles, from relying on
LinestoParagraphsinstead.Fixes #715
Needs Review: @diegoreymendez
Thanks in advance!
To test:
Verify that the Blockquote Style does not get removed from the
Helloword.Please note that after hitting backspace 6 times, the caret will be right by the
Helloword, but it won't be visible. To be addressed in another PR!