-
Notifications
You must be signed in to change notification settings - Fork 149
iOS 11: Delete Backwards Workaround #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is mostly fine with one exception. Try this:
- Apply any header style
- Type something
- Press ENTER once
- Type "1"
- Backspace once.
PROBLEM: The header style is applied to the second line.
To do:
We should add a unit test for this scenario.
We should check if the care is at the beginning of the paragraph:
- If the care is at the beginning of a paragraph, we should only copy regular (non-paragraph) styles.
- If the care is anywhere else, we should copy all styles.
|
@diegoreymendez nice catch!. The scenario outlined has it's own issue (#747), and it's own PR though (#754). Would you like me to merge that PR in here? Edited: |
diegoreymendez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a golden PR. Nice changes!
|
Need this PR in to test the following PR in line. We have several, so I'm overriding Circle for now. We'll be letting Circle run for the last PR, so that all of the changes are checked. |
|
Thanks for the review Diego! |
Details:
iOS 11's
insertText/deleteBackward's inner workings result into loosing the typingAttributes. This fix is analog to the one introduced via #725.Fixes #749
cc @diegoreymendez
Thanks in advance!
To test:
echaracter is in italics.