Remove attributes on attachments #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to allow removal of attributes on Media attachments.
For example if we have this html:
<img src="http://wordpress.com/logo.png" data-wp="ID">And then I want to remove the
data-wpusing theextraAttributesproperty onMediaAttachmentI was unable to do it because it was being stored on the HTMLRepresentation of that element and saved back to the HTML.The test method added on the PR show this clearer.
The change I'm proposing is to not save the original HTMLRepresentation for Media Attachments because they already have a mechanism to save all the attributes in them.
I'm open to other suggestion to solve this issue.