Customizable Blockquote Style #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// | ||
| fileprivate var textAttachmentImageProvider = [TextViewAttachmentImageProvider]() | ||
|
|
||
| // MARK: - Properties: Formatting |
Contributor
There was a problem hiding this comment.
Why are we removing the mark?
Contributor
There was a problem hiding this comment.
PS: if we want to rename this I'm fine, but it's a good one since all of it's content is related to formatting.
Contributor
Author
There was a problem hiding this comment.
Related to the change few lines above. This is part of the delegates section, so it's a bit of redundant
Aztec/Classes/TextKit/TextView.swift
Outdated
|
|
||
| // MARK: - Properties: Text Storage | ||
|
|
||
| // MARK: - TextKit Aztec Subclass'ess |
Contributor
There was a problem hiding this comment.
/s/Subclass'ess/Subclasses
No need for the apostrophe / single-quote.
Aztec/Classes/TextKit/TextView.swift
Outdated
| } | ||
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
No need for 3 lines.
diegoreymendez
approved these changes
Oct 30, 2017
Contributor
Author
|
Thanks for the review sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In this PR we're adding three new TextView properties:
Details:
Because of the
dynamickeyword, the three new properties are compatible with Apple'sUIAppearance()mechanism. This allows us to do the following:textView.blockquoteBackgroundColor = .greenTextView.appearance().blockquoteBackgroundColor = .greenApple's
appearance()mechanism also allows for customization when contained in a specific ViewController, or define the UX for a specific set of traits.Testing:
EditorDemoViewController.swifttextView.blockquoteBackgroundColor = .greenVerify that the blockquote is green.