Fixes large text memory issue. #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
suggested changes
Nov 9, 2017
| return textStore.attributes(at: location, effectiveRange: range) | ||
| } | ||
|
|
||
| private func replaceTextStoreString(_ range: NSRange, with string: String) { |
Contributor
There was a problem hiding this comment.
Considering String.replaceSubrange() is of complexity O(m) for most scenarios (where m is the sum of the length of the cached string and the modification), this method should be replaced by:
textStoreString = textStore.string
| detectAttachmentRemoved(in: range) | ||
| textStore.replaceCharacters(in: range, with: str) | ||
|
|
||
| replaceTextStoreString(range, with: str) |
Contributor
There was a problem hiding this comment.
We should move the update logic inside of override func edited() (inside the next call in this method), and only trigger it for .editedCharacters.
That way we don't need to call both at several point in the app.
Contributor
|
@azone - Very nice find and very nice approach. Added a few comments on further improvements. |
diegoreymendez
approved these changes
Nov 15, 2017
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
Aproving, since we need these changes. I'll address any changes separately.
Contributor
|
Merging since Travis is stuck. |
diegoreymendez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #791
To test: