Skip to content

Make header's font size customizable #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2017
Merged

Make header's font size customizable #808

merged 1 commit into from
Nov 8, 2017

Conversation

@azone
Copy link
Contributor

@azone azone commented Nov 6, 2017

To test:

Configuration header size:

Header.HeaderType.fontSizeMap[.h1] = 24
Header.HeaderType.fontSizeMap[.h2] = 20
Header.HeaderType.fontSizeMap[.h3] = 18
Header.HeaderType.fontSizeMap[.h1] = 16
Header.HeaderType.fontSizeMap[.h2] = 14
Header.HeaderType.fontSizeMap[.h3] = 12

@jleandroperez jleandroperez self-requested a review November 8, 2017 13:05
jleandroperez
jleandroperez approved these changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!! thank you sir!

:shipit:

@jleandroperez jleandroperez merged commit 89495e7 into wordpress-mobile:develop Nov 8, 2017
@jleandroperez jleandroperez added this to the Next Stable milestone Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jleandroperez jleandroperez jleandroperez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@azone azone

Labels

[Type] Enhancement

Projects

None yet

Milestone

Version 1.0.0 Beta 15

Development

Successfully merging this pull request may close these issues.

2 participants

@azone @jleandroperez