Migrates the project to Swift 4. #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /// | ||
| /// Returns the collection of Typing Attributes, with all of the available 'String' keys properly converted into | ||
| /// NSAttributedStringKey. Also known as: what you would expect from the SDK. |
| @@ -0,0 +1,48 @@ | |||
| import Foundation | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Not really important, but remove 1 line here.
diegoreymendez
approved these changes
Nov 7, 2017
Contributor
Author
|
Let's do it! thanks for the review @diegoreymendez !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
It's nearly 2018, and with Swift 5 around the corner... what a best time to flick the switch, and move over to Swift 4. Right?
Fixes #807
To test: