Skip to content

Japanese text issues for 1.0.0-beta.14. #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2017
Merged

Japanese text issues for 1.0.0-beta.14. #825

merged 3 commits into from
Nov 15, 2017

Conversation

@diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Nov 15, 2017

Description

Fixes #709 for Beta 14 (It's the same fix as #824 but for Beta 14).

It seems we were missing a call to edited().

Testing

  1. Launch the app
  2. Type anything using the Japanese keyboard.
  3. Switch to HTML mode and edit some more.
  4. Switch back to visual mode and make sure all Japanese characters are properly rendered throughout the session.

@diegoreymendez diegoreymendez added this to the Bugfixes for Beta 14 milestone Nov 15, 2017
@diegoreymendez diegoreymendez self-assigned this Nov 15, 2017
@diegoreymendez diegoreymendez changed the title Issue/709 japanese text issues for 8.8 Japanese text issues for 1.0.0-beta.14. Nov 15, 2017
@diegoreymendez diegoreymendez changed the base branch from develop to release/1.0.0-beta.14 November 15, 2017 16:35
bummytime
bummytime approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@diegoreymendez
Copy link
Contributor Author

diegoreymendez commented Nov 15, 2017

Thanks @bummytime !

@diegoreymendez diegoreymendez merged commit 3137c8c into release/1.0.0-beta.14 Nov 15, 2017
@diegoreymendez diegoreymendez deleted the issue/709-japanese-text-issues-for-8.8 branch November 15, 2017 16:38
@rachelmcr rachelmcr mentioned this pull request Oct 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bummytime bummytime bummytime approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@diegoreymendez diegoreymendez

Labels

[Priority] High [Type] Bug

Projects

None yet

Milestone

Version 1.0.0 Beta 14.1

Development

Successfully merging this pull request may close these issues.

3 participants

@diegoreymendez @bummytime