Skip to content

Conversation

@SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 16, 2017

Fixes #796

This is a clone of this PR #797 with conflicts sorted and some code simplication.

To test:

  • Start the demo app
  • Open the empty demo
  • Add an image object that takes the full width of the editor
  • Activate blockquote for that paragraph that has media
  • Check that the image stays inside the blockquote background.

Kudos to @azone !

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works even better!!

:shipit:

@SergioEstevao SergioEstevao merged commit f8c9bc6 into develop Nov 20, 2017
@SergioEstevao SergioEstevao deleted the correct-media-attachment-width branch November 20, 2017 13:22
@diegoreymendez diegoreymendez changed the title Correct media attachment width Fixes media attachment width. Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants