Skip to content

Conversation

@SergioEstevao
Copy link
Contributor

Fixes #830

To test:

  • Open the demo app
  • Add an image
  • Switch to HTML
  • Check if the full attribute is applied

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!!

:shipit:

@SergioEstevao SergioEstevao merged commit a836fd1 into develop Nov 20, 2017
@SergioEstevao SergioEstevao deleted the issue/830_image_output_html_css_for_size_full branch November 20, 2017 13:22
@diegoreymendez diegoreymendez changed the title Image output html css for size full Defaults image attachment size to "full" Nov 24, 2017
@designsimply
Copy link

I tested with iPhone 6S, iOS 11.1.2, WPiOS 8.9.0.20171122 and I was unable to see the class="size-full" attribute.

Steps to reproduce:

  1. Go to WPiOS > Blog Posts > + and add a title.
  2. Insert an image from the device's media.
  3. View the HTML to see if class="size-full" is present.
  4. Go to WPiOS > Blog Posts > + and add a title.
  5. Insert an image from the blog's media library.
  6. View the HTML to see if class="size-full" is present.

Result: when the image was inserted from the device I saw class="wp-image=11507 and when the image was inserted from the media library there were no attributes other than src.

img_1744

img_1745

@diegoreymendez
Copy link
Contributor

@designsimply - Can you move this info to the issue here? (as opposed to the PR)

It will help ensure the feedback is properly tracked and there's an explanation if we need to reopen the issue.

Thank you!

@SergioEstevao
Copy link
Contributor Author

Humm by default on the main app I don't think we are setting any size attribute. Should the size-full be the default @designsimply ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants