MediaAttachment: Encapsulating Draw Methods! #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
added
[Type] Tech Debt / Tech Task
and removed
[Status] Not Ready For Review
labels
Contributor
Author
|
@diegoreymendez @SergioEstevao ready for review gentlemen!. The Travis CI issue is related to a breaking UI test, non related to these changes. PS: It'll probably be easier to check the code by means of Kaleidoscope! Thanks in advance! |
diegoreymendez
approved these changes
Dec 15, 2017
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
Check out my comments, then merge.
|
|
||
| /// The margin apply to the images being displayed. This is to avoid that two images in a row get | ||
| /// glued together. | ||
| /// The margin apply to the images being displayed. This is to avoid that two images in a row get glued together. |
Contributor
There was a problem hiding this comment.
Missing "to" after "margin".
| var padding = (textContainer?.lineFragmentPadding ?? 0) * 2 | ||
| if let storage = textContainer?.layoutManager?.textStorage, | ||
| let paragraphStyle = storage.attribute(.paragraphStyle, at: charIndex, effectiveRange: nil) as? NSParagraphStyle | ||
| { |
Contributor
There was a problem hiding this comment.
Brace on previous line for consistency.
Contributor
Author
|
Comments addressed, thanks for the review Diego!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In this PR we're:
if returnclauses withguard. Why? Because we reduce the indentation level, it's easier to read, and looks beautiful.To test:
2.1. Verify that the progress bar works properly
2.2. Verify that during the upload OP, there's an overlay
3.1. Verify that an overlay gets displayed
3.2. Verify that there's an asset rendered at the center of the image
3.3. Verify that below the center's asset, there's a text label!
I was in the neighborhood, and needed to change few things. This PR will be followed up by another one, in charge of rendering Figure / Figcaption elements.
cc @diegoreymendez @SergioEstevao
Thanks in advance!