test: Assert iOS WebView globals configuration#119
Merged
Conversation
dcalhoun
added
the
[Type] Automated Testing
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests to assert the iOS WebView global configuration and updates the initializer for WebViewGlobal to throw a proper error when provided with an invalid JavaScript identifier.
- Adds tests for various WebViewGlobal value conversions and identifier validations.
- Updates the WebViewGlobal initializer to throw an error instead of calling preconditionFailure.
- Introduces a new error enum (WebViewGlobalError) for improved error handling.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ios/Tests/GutenbergKitTests/EditorConfigurationTests.swift | Added comprehensive unit tests for validating JavaScript identifiers and conversion of WebViewGlobalValue. |
| ios/Sources/GutenbergKit/Sources/EditorConfiguration.swift | Modified the initializer to throw an error on invalid JavaScript identifiers and added the WebViewGlobalError enum. |
kean
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Assert iOS WebView global configuration. Close CMM-284.
Related: wordpress-mobile/WordPress-iOS#24485
Why?
Avoid regressions within the regex and string manipulation.
How?
Add automated unit tests.
Testing Instructions
N/A, no user-facing changes.
Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.