Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces automated tests for the useMediaUpload hook to ensure its functionality regarding filter registration, unmount behavior, and interaction with the media library.
- Added a test file for the hook with multiple assertions covering filter registration and cleanup.
- Added a mock file for WordPress hooks to support testing.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/editor/test/use-media-upload.test.jsx | New test file asserting hook behavior including filter addition, removal, and media library interaction. |
| mocks/@wordpress/hooks.js | Provides mock implementations of addFilter and removeFilter for testing purposes. |
Comments suppressed due to low confidence (1)
src/components/editor/test/use-media-upload.test.jsx:64
- [nitpick] Consider renaming 'FilterCallback' to a more descriptive name (e.g., 'MediaUploadComponent') to clarify its role in rendering the filter component.
let FilterCallback;
b9c7a7b to
1a8b6c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Assert
useMediaUploadhook functionality.Why?
Improve stability.
How?
Add automated test file.
Testing Instructions
N/A, no user-facing changes.
Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.