Conversation
dcalhoun
approved these changes
May 28, 2025
Member
dcalhoun
left a comment
There was a problem hiding this comment.
I tested running the following and all functioned as expected:
- The GBK Demo app.
- WP-Android with a GBK composite build.
- WP-Android with a GBK binary depedency.
./gradlew assembleRelease../gradlew lintRelease
I note that the previous Gradle upgrade included additional file changes:
android/gradle/wrapper/gradle-wrapper.jarandroid/gradle/wrapper/gradle-wrapper.propertiesandroid/gradlewandroid/gradlew.bat
I presume we do not need to make similar changes, but @ParaskP7 will you confirm?
Contributor
You're right @nbradbury , no need to do any Gradle up/downgrade with this change, downgrading and thus touching AGP only should be all we need from this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a companion to this WPAndroid PR, this PR reverts AGP to v8.7.3. Please refer to that WPAndroid PR for details.