-
Notifications
You must be signed in to change notification settings - Fork 3
Faster and more robust editor asset management #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
5ef6674
Add EditorService
kean e60b72d
Remove editorAssetsEndpoint parameter from EditorConfiguration
kean 0d7305f
Move assets management to EditorService
kean b67f3b2
Add logging
kean be494ff
Add a way to clear loaded assets
kean b8b92ae
Inject manifest directly without EditorAssetsProvider
kean d85b7e9
Simplify CachedAssetSchemeHandler
kean e1ac3a9
Move private methods below
kean 463bc51
Add manifest verification
kean 4746e07
Make refresh non-throwing
kean 5fb910a
Add State file as an indicator where the request finished or not
kean 6ff7728
Fix build errors
kean a55b1a9
Remove EditorAssetsManifest
kean 82d7dd3
Fix build errors
kean 5b27865
Add shared EditorService instances
kean e77b8e6
Cleanup
kean 28f03b0
Do not refresh too often
kean daf5106
Use Application directory instead of Documents
kean 8073026
Make logging a cross-cutting concern
kean 39b4200
Cleanup
kean ad776c6
Replace safeFilename with sha1
kean 9e4a8de
Cleanup
kean dac7dc6
Trigger refresh automatically in the background after teh editor is l…
kean 3dde90c
Fix typos
kean 2965a20
Add performance tracking for dependencies
kean 763b0ff
Simlify warmup for editor
kean 05a0ac2
Make dependencies func non-throwing
kean d245387
Fix typos in EditorManifestTests
kean fdeae8b
Add missing startEditorSetup call
kean 3c0c532
Swift to Application Support directory
kean 0405760
Add EditorSeviceTests
kean 503da92
Add loadsSettingsWhenAssetFails
kean 8fd121f
Simplify fetchAssets
kean 2db64e6
Add upgradesManifestOnVersionChange
kean 063b102
Refactor tests
kean ac14d11
Simplify getCachedAsset
kean cae905c
Add assertion to check that the assets are actually available
kean 378eccc
Cache processed manifest (takes ~100ms)
kean 2325b3b
Add cleanupOrphanedAssets
kean bff54bd
Fix concurrency warnings
kean 8ddface
Revert createBundledConfiguration change
kean 7a51bf7
Restore EditorAssetsProvider and revert manifest injection changes
kean 7f0ddd0
Fix LogLevel references to use EditorLogLevel
kean 1613171
Update tests
kean 1a35a1b
Add more unit tests
kean 25fdafb
Remove empty file
kean 40eff71
Revert the preview change
kean 1b09406
Restore editorAssetsEndpoint parameter
kean 680242d
Remove log for local files
kean 22ff2c8
Clean up the merge mess
jkmassel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 0 additions & 108 deletions
108
ios/Sources/GutenbergKit/Sources/Cache/CachedAssetSchemeHandler.swift
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely worthwhile consistently using
selfin thisswitch.