fix: Add type checks before wrapping wp.ajax methods #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address PR feedback about potential race condition. The code now checks if `window.wp.ajax.send` and `window.wp.ajax.post` are functions before wrapping them. This prevents TypeError when calling the wrapped function if the original method was undefined during configuration. Update tests to verify that missing methods remain undefined rather than being wrapped with an undefined reference.
dcalhoun
merged commit 394bce2
into
feat/authorize-ajax-with-application-passwords
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add type checks before wrapping
wp.ajax.sendandwp.ajax.postmethods in the AJAX configuration.Why?
This addresses PR review feedback about a potential race condition. If
window.wp.ajax.sendorwindow.wp.ajax.postare undefined whenconfigureAjax()executes, the wrapped function would throw aTypeErrorwhen invoked (calling.call()on undefined).References: #181
How?
typeof window.wp.ajax.send === 'function'check before wrapping thesendmethodtypeof window.wp.ajax.post === 'function'check before wrapping thepostmethodTesting Instructions
npm run test:unitajax.test.jspassAccessibility Testing Instructions
N/A - This is a JavaScript utility change with no UI impact.
Screenshots or screencast
N/A - No visual changes.