fix: Register MediaFileSchemeHandler for native iOS media insertion#309
Merged
fix: Register MediaFileSchemeHandler for native iOS media insertion#309
Conversation
The `MediaFileSchemeHandler` was defined but not registered with the `WKWebView` configuration, causing media insertion from the native iOS block inserter to fail. Selected photos and videos from the device's photo library were not displaying in the editor because the WebView couldn't load `gbk-media-file://` URLs. This fix adds the missing scheme handler registration in `EditorViewController.init()`, restoring functionality that was accidentally removed in commit 6486090.
dcalhoun
force-pushed
the
fix/native-ios-inserter-inserts-media
branch
from
97d47e5 to
613fc97
Compare
dcalhoun
force-pushed
the
fix/native-ios-inserter-inserts-media
branch
from
613fc97 to
76c0546
Compare
kean
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Registers the
MediaFileSchemeHandlerwith the WKWebView configuration so that media selected from the device's photo library can be displayed in the editor.Why?
When inserting media from the native iOS block inserter, selected photos and videos were not appearing in the editor. The
MediaFileSchemeHandlerfor thegbk-media-file://URL scheme was defined but never registered with the WebView configuration.This was a regression introduced in commit
6486090("Add iOS Preload List #250") whenEditorViewControllerwas refactored and the scheme handler registration was removed but not restored.Fixes CMM-1207.
How?
Added the missing scheme handler registration in
EditorViewController.init():Also added test coverage to verify the scheme handler is properly registered.
Testing Instructions
Accessibility Testing Instructions
N/A - This fix restores existing functionality without UI changes.