Skip to content

fix: resolve failures from @wordpress/edit-post bump (#346)#351

Merged
dcalhoun merged 3 commits intotrunkfrom
build/bump-wordpress-modules
Mar 5, 2026
Merged

fix: resolve failures from @wordpress/edit-post bump (#346)#351
dcalhoun merged 3 commits intotrunkfrom
build/bump-wordpress-modules

Conversation

@dcalhoun
Copy link
Copy Markdown
Member

@dcalhoun dcalhoun commented Mar 4, 2026

What?

Fixes issues introduced by the Dependabot PR #346 (@wordpress/edit-post 8.39.0 → 8.40.1), which was merged with failing E2E tests.

Why?

PR #346 bumped @wordpress/edit-post, which transitively bumped @wordpress/block-library from 9.39.0 to 9.41.0. This upstream change migrated the Button block's Width control from a custom InspectorControls panel to the standard dimensions.width block support (WordPress/gutenberg#74242). As a result:

  1. Missing inspector tabs: The Button block no longer has fills in the default InspectorControls slot (Settings tab), leaving only the Styles tab. With a single tab, Gutenberg renders a flat layout instead of tabbed Settings/Styles panels. This is the intended upstream behavior.
  2. Broken fieldset styles: The fieldset reset styles were scoped to .gutenberg-kit-visual-editor, but the block settings panel renders in a Popover outside that element, so the styles were not applied.

How?

  1. E2E test fix: Removed the Styles tab click from the color-gradient spec since the Button block inspector no longer renders tabs.
  2. Fieldset style fix: Moved the fieldset reset styles from .gutenberg-kit-visual-editor to the .gutenberg-kit root scope so they apply globally, including to popovers.

Testing Instructions

Verify the CI checks pass.

Accessibility Testing Instructions

N/A — no UI changes; the flat inspector layout is the upstream Gutenberg behavior.

Screenshots or screencast

Before After
before-1 after-1
before-2 after-2

dcalhoun added 3 commits March 4, 2026 15:28
The block settings panel is rendered in a popover outside of the
`.gutenberg-kit-visual-editor` element, so the fieldset reset styles
scoped to that element were not being applied. Move them to the
`.gutenberg-kit` root scope so they apply globally.
The button block no longer renders Settings/Styles tabs in the
inspector after the block-library upgrade (9.39→9.41). The Width
control moved from a custom InspectorControls panel to a block
support, leaving only one tab's worth of content, so Gutenberg
renders a flat layout instead of tabs.
@dcalhoun dcalhoun added [Type] Bug An existing feature does not function as intended dependencies Pull requests that update a dependency file labels Mar 4, 2026
@dcalhoun dcalhoun marked this pull request as ready for review March 4, 2026 21:19
Copy link
Copy Markdown
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify the CI checks pass.

CI is passing so this is good to go :shipit:

@dcalhoun dcalhoun merged commit 64c0f7a into trunk Mar 5, 2026
14 checks passed
@dcalhoun dcalhoun deleted the build/bump-wordpress-modules branch March 5, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants