fix: resolve failures from @wordpress/edit-post bump (#346)#351
Merged
fix: resolve failures from @wordpress/edit-post bump (#346)#351
Conversation
The block settings panel is rendered in a popover outside of the `.gutenberg-kit-visual-editor` element, so the fieldset reset styles scoped to that element were not being applied. Move them to the `.gutenberg-kit` root scope so they apply globally.
The button block no longer renders Settings/Styles tabs in the inspector after the block-library upgrade (9.39→9.41). The Width control moved from a custom InspectorControls panel to a block support, leaving only one tab's worth of content, so Gutenberg renders a flat layout instead of tabs.
nbradbury
approved these changes
Mar 5, 2026
Contributor
nbradbury
left a comment
There was a problem hiding this comment.
Verify the CI checks pass.
CI is passing so this is good to go ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes issues introduced by the Dependabot PR #346 (
@wordpress/edit-post8.39.0 → 8.40.1), which was merged with failing E2E tests.Why?
PR #346 bumped
@wordpress/edit-post, which transitively bumped@wordpress/block-libraryfrom 9.39.0 to 9.41.0. This upstream change migrated the Button block's Width control from a customInspectorControlspanel to the standarddimensions.widthblock support (WordPress/gutenberg#74242). As a result:InspectorControlsslot (Settings tab), leaving only the Styles tab. With a single tab, Gutenberg renders a flat layout instead of tabbed Settings/Styles panels. This is the intended upstream behavior..gutenberg-kit-visual-editor, but the block settings panel renders in aPopoveroutside that element, so the styles were not applied.How?
Stylestab click from thecolor-gradientspec since the Button block inspector no longer renders tabs..gutenberg-kit-visual-editorto the.gutenberg-kitroot scope so they apply globally, including to popovers.Testing Instructions
Verify the CI checks pass.
Accessibility Testing Instructions
N/A — no UI changes; the flat inspector layout is the upstream Gutenberg behavior.
Screenshots or screencast